Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix reloading of jobs & rotate logs #5

Merged
merged 7 commits into from
Nov 21, 2023
Merged

fix reloading of jobs & rotate logs #5

merged 7 commits into from
Nov 21, 2023

Conversation

Fabio1988
Copy link
Contributor

@Fabio1988 Fabio1988 commented Nov 18, 2023 •
edited
Loading

  • fix reloading of jobs without restarting rotom
  • allow to rotate log files stored to disk

Log format:

[2023-11-18T17:17:01.454Z] [INFO] [rotom] Rotom Device Controller Started
[2023-11-18T17:17:01.455Z] [INFO] [rotom] Device port 7070 Controller port 7071
[2023-11-18T17:17:01.455Z] [INFO] [rotom] Loaded 2 jobs
[2023-11-18T17:17:01.471Z] [INFO] [rotom] Webserver running on http://localhost:7072 listening on 127.0.0.1

@Fabio1988 Fabio1988 requested a review from na-ji November 18, 2023 17:21
@Fabio1988 Fabio1988 changed the title rotate logs fix reloading of jobs & rotate logs Nov 18, 2023
@jfberry
Copy link
Contributor

jfberry commented Nov 18, 2023

Does job reloading work with new files? I think perhaps it should track the folder including ‘add’

@Fabio1988
Copy link
Contributor Author

We can also check for all file changes in that folder, even if a file is deleted we can include that change :)

@jfberry
Copy link
Contributor

jfberry commented Nov 18, 2023

I think if you trace the folder you don’t include the * - a while since I played with chokidar

na-ji
na-ji approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@na-ji na-ji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

package.json Outdated Show resolved Hide resolved
@Fabio1988 Fabio1988 merged commit 3d849aa into main Nov 21, 2023
10 checks passed
@Fabio1988 Fabio1988 deleted the logger branch November 21, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@na-ji na-ji na-ji approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Fabio1988 @jfberry @na-ji